⚠️ No Changeset found

Latest commit: 943866a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

The latest updates on your projects. Learn more about Vercel for Git ↗︎

@marcchehab is attempting to deploy a commit to the Datopian Team on Vercel.

A member of the Team first needs to authorize it.

Hello @marcchehab! Thank you so much for waiting so patiently for our review! 🙏 🌸 I'll make sure we merge your code ASAP!

As for the missing arrows: they are just not positioned correctly. Since the pseudo-elements are "absolutely" positioned, they need some "relative" ancestor. And so they show up after adding position: relative to .callout-title class.

However, as you can see, they are not perfectly centered vertically. This can be fixed with CSS though to achieve this:

See my suggestions to your CSS styles.

🏆 Would be nice to have a simple test for this feature in test/remark-callouts.spec.ts, but it's not required.

Overall, great work, and I can't wait to have it shipped! 🚀

@olayway thanks for your kind corrections 🥳 I'll immediately port those to my main branch 😬 I'll have a look if I can write a testfile, I'll have to figure out how to use mocha with ts.

Btw: Once we merge this, I can ship another PR to correct a bug in callouts (if something in the title inserts a new element, e.g. a bold text, it breaks the title)

I can't get mocha to run, so I can't write tests... (Among other things I tried to run mocha in packages/remark-callouts, but no success so far, even though its clearly using your .mocharc.yaml)

I can't get mocha to run, so I can't write tests... (Among other things I tried to run mocha in packages/remark-callouts, but no success so far, even though its clearly using your .mocharc.yaml)

@marcchehab Thank you for giving it a go! Try running this in the root of the repo:

pnpm i
pnpm nx test remark-callouts

@marcchehab is this good to merge in your opinion? did you managed to make the changes?